#8099: pari fails to build in Open Solaris x64 as 64 bit if CFLAGS is not set
----------------------------+-----------------------------------------------
Reporter: jsp | Owner: drkirkby
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: solaris | Keywords:
Author: Jaap Spies | Upstream: N/A
Reviewer: David Kirkby | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by drkirkby):
Replying to [comment:3 jsp]:
> Replying to [comment:2 drkirkby]:
> > The comment in SPKG.txt is inaccurate, as the patch is not specific to
Open Solaris.
> >
> > A more accurate comment would be.
> >
> > * #8099 Ensures the compiler flag -m64 is added at any time SAGE64
was
> > set to "yes" - previously this was only happening on OS X. This
should aid
> > building 64-bit on any platform, although it has only been tested on
Open
> > Solaris.
> >
> > It's far better to open a ticket for the bug first, before trying to
fix it. Then the ticket number can be placed in the comments in SPKG.txt.
> >
>
> This was *exactly* what I did!
Sorry. The only point I would make is that the trac ticket should go on
the same bullet point. I must admit I don't see why it makes a huge
difference, but I was told the file is parsed, and so the format is
important. I must admit, I've no idea what parses it.
> > It would be good to see some evidence the patch actually works. Such
as byshowing the output of the 'ldd' command, that the library and/or
binary is now a 64-bit one. For some packages, it is unnecessary to add
-m64 and forothers, adding it does not generate 64-bit binaries. For zlib,
adding -m64 stops the build of shared libraries.
> >
>
> I opened the ticket *because* without -m64 set pari build in 32 bit!
But the point I am making is that there is nothing to show that the
library now builds 64-bit. Probably showing the output of the 'ldd'
command before and after a patch would be best. I am the first to admit I
have not always done this, but I intend to now, as I am aware just adding
-m64 is not the magic solution to solve all these 64-bit issues.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8099#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
