#8053: graph editor minor bugs and improvements
----------------------------+-----------------------------------------------
Reporter: rkirov | Owner: was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.3.2
Component: notebook | Keywords:
Author: rkirov | Upstream: N/A
Reviewer: Mitesh Patel | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by mpatel):
* reviewer: => Mitesh Patel
Comment:
The patch looks good. The new features and fixes are great!
* I recommend running `graph_editor.js` through [http://www.jslint.com/
JSLint] on its "The Good Parts" setting. (Feel free to set `white: true`
at the top of the file, since the beautifier now takes care of that.). It
found:
* Missing `;` at the end of line 6.
* `removed_node` is not defined. I suggest adding it to line 6.
* Do people find it useful to turn off live mode but still be able to
adjust the sliders? I often do this to "freeze" movement while I make
adjustments, but I'm definitely not a typical user.
* Until they read the help text, users may expect the "Undo" button to
undo the last ''action''. Can you extend its capability? Or should we
call it "Undelete" and restore a deleted edge, as well?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8053#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
