#8140: words.CharacteristicSturmianWord does not do what it says
-----------------------------+----------------------------------------------
Reporter: slabbe | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: combinatorics | Keywords:
Author: slabbe | Upstream: N/A
Reviewer: abmasse | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => abmasse
* author: => slabbe
Comment:
I reviewed this patch and made the following minor modifications, mostly
in the documentation:
- I gave three different equivalent definitions of characteristic Sturmian
word as presented in the Lothaire book.
- I changed the name of the variable `cf` for `slope` in the
characteristic Sturmian.
- I modified the NotImplementedError raised by the three functions by a
ValueError. It seems more appropriate since values of slope are in general
assumed to be in (0,1). Sébastien, if you still insist on keeping
NotImplementedError, I would put a different message, something like "not
implemented for values out of (0,1)"
- I made other minor changes and updated the examples in consequence.
All tests passed, the code seems good and correct the problem mentionned
in this ticket. The doc is alright too.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8140#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
