#8115: bad patching practice in cddlib-094f.p2.spkg
-------------------------------+--------------------------------------------
Reporter: mvngu | Owner: tbd
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.3.2
Component: packages | Resolution:
Keywords: cddlib, polyhedra | Author: Volker Braun
Upstream: N/A | Reviewer: Minh Van Nguyen
Merged: | Work_issues:
-------------------------------+--------------------------------------------
Old description:
> A problem with cddlib-094f.p2.spkg is that it patches upstream source
> using a patch file, rather than copying a patched file over to the
> appropriate place under the src/ directory. Consequently, there is no
> clean separation between upstream source and patches that we apply to
> cddlib-094f. Looking at spkg-install of cddlib-094f.p2.spkg, you get
> these two lines for applying Sage-specific patches:
> {{{
> cp patches/allfaces.c src/src/
>
> patch -p0 < patches/cdd_both_reps-make.patch
> }}}
> The first line is the preferred way to patch an upstream source because
> it copies the patched file patches/allfaces.c over to src/src/. This
> issue is reported on [http://groups.google.com/group/sage-
> devel/browse_thread/thread/e599fd37de909264 sage-devel].
> [[BR]][[BR]]
>
> '''Note to release manager:''' cddlib-094f.p?.spkg places two new
> binaries under the directory `$SAGE_LOCAL/bin`, in particular:
> {{{
> [mv...@mod bin]$ pwd
> /scratch/mvngu/release/sage-4.3.2.alpha1/local/bin
> [mv...@mod bin]$ hg st
> ? cdd_both_reps
> ? cdd_both_reps_gmp
> }}}
> These are required by the rewritten polyhedra package. A patch to
> `$SAGE_LOCAL/bin/.hgignore` is attached.
New description:
A problem with cddlib-094f.p2.spkg is that it patches upstream source
using a patch file, rather than copying a patched file over to the
appropriate place under the src/ directory. Consequently, there is no
clean separation between upstream source and patches that we apply to
cddlib-094f. Looking at spkg-install of cddlib-094f.p2.spkg, you get these
two lines for applying Sage-specific patches:
{{{
cp patches/allfaces.c src/src/
patch -p0 < patches/cdd_both_reps-make.patch
}}}
The first line is the preferred way to patch an upstream source because it
copies the patched file patches/allfaces.c over to src/src/. This issue is
reported on [http://groups.google.com/group/sage-
devel/browse_thread/thread/e599fd37de909264 sage-devel].
[[BR]][[BR]]
This depends on #8179.
--
Comment(by mvngu):
I don't know how long it would take to positively review this ticket. So I
have moved [http://trac.sagemath.org/sage_trac/attachment/ticket/8115
/cddlib-local-bin-hgignore.patch cddlib-local-bin-hgignore.patch] over to
#8179.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8115#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
