#8115: bad patching practice in cddlib-094f.p2.spkg
-------------------------------+--------------------------------------------
 Reporter:  mvngu              |         Owner:  tbd            
     Type:  defect             |        Status:  needs_work     
 Priority:  major              |     Milestone:  sage-4.3.3     
Component:  packages           |    Resolution:                 
 Keywords:  cddlib, polyhedra  |        Author:  Minh Van Nguyen
 Upstream:  N/A                |      Reviewer:                 
   Merged:                     |   Work_issues:                 
-------------------------------+--------------------------------------------
Changes (by vbraun):

  * status:  needs_review => needs_work


Comment:

 The .p3 will break polyhedra.py, please don't apply that. You need those
 two parts:

 {{{
     # Required by sage.geometry.polyhedra
     cp patches/cdd_both_reps.c src/src/
     cp patches/cdd_both_reps.c src/src-gmp/
 }}}

 To actually compile these extra .c sources, you need the updated
 Makefile.am's and rerun autoconf/automake and keep track of the
 autogenerated files.

 Can you be a bit clearer on what you want to separate out? Do you want a
 spkg with all updates and fixes except the libtools stuff? I can split
 that out but I don't quite see the point. We'd have to test one new set of
 autotools-files and then, with the shared library update, trash those
 autogenerated files and try yet another set of autogenerated files.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8115#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to