#2203: Add a traveling salesman problem solver
----------------------------+-----------------------------------------------
   Reporter:  jason         |       Owner:  jason       
       Type:  enhancement   |      Status:  needs_review
   Priority:  major         |   Milestone:  sage-4.3.3  
  Component:  graph theory  |    Keywords:              
     Author:                |    Upstream:  N/A         
   Reviewer:                |      Merged:              
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by jason):

 A couple of somewhat picky notes from just reading through the code:

  * "traveling" is spelled with one 'l' in American English.  See
 
[http://dictionary.oed.com/cgi/entry/50256805?query_type=word&queryword=travel&first=1&max_to_show=10&sort_type=alpha&search_id
 =CNCH-0vTuPN-10331&result_place=2|Oxford English Dictionary],
 "Derivatives, as travelled, -er, -ing, etc. are usually spelt with ll in
 Gr. Britain, with single l in America."  With no offense to those across
 the Great Pond, it seems that we've standardized on American English for
 spelling.

  * I don't think there is a need for the "is_hamiltonian" note in the TSP
 function.

  * If these functions require an optional package, it should probably
 mention that as a note or warning in the documentation.

 I'll try applying this patch soon to have a more thorough review.  It
 looks really nice!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2203#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to