#6812: Enumerate integer list up to the action of a Permutation Group
-----------------------------+----------------------------------------------
Reporter: nborie | Owner: nborie
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.3
Component: combinatorics | Keywords: enumeration, integer, list,
permutation, group
Author: nborie | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by SimonKing):
* upstream: => N/A
Comment:
Hi!
This is not a review yet, just some remarks.
Indeed it seems to me that the comments and the documentation should be
proof read by a native speaker. I am not a native speaker, I'm afraid.
I also suggest to rename some methods. For example, the purpose of
"generate_list_of_sum" is not clear from that name:
* "generate" suggests a process. Therefore, I expected that the method
would return an iterator. But in fact, an actual list is returned. A
similar statement applies to "get_orbit". Why not simply "orbit"?
* "list_of_sums" is not clear at all. I mean, there is the notion of
"partition", so, there is no reason to describe it as "list of sums". Of
course, not all partitions are returned, but representatives for each
permutation class of partitions.
So, I think "partition_class_representatives" or slightly less precise
"partition_classes" would be clearer.
And "generate_canonicals": The return value is the list of canonical
representatives of all children of the input. So, why not
"children_representatives" or "canonical_children"?
Best regards, Simon
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6812#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
