#7765: In sage-4.3, the command "sage -bdist" is broken on OS X
-----------------------------------+----------------------------------------
   Reporter:  was                  |       Owner:  tbd         
       Type:  defect               |      Status:  needs_review
   Priority:  blocker              |   Milestone:  sage-4.3.3  
  Component:  distribution         |    Keywords:              
     Author:  Karl-Dieter Crisman  |    Upstream:  N/A         
   Reviewer:  William Stein        |      Merged:              
Work_issues:                       |  
-----------------------------------+----------------------------------------
Changes (by newvalueoldvalue):

  * status:  needs_work => needs_review
  * reviewer:  => William Stein
  * author:  => Karl-Dieter Crisman


Comment:

 Replying to [comment:2 was]:
 > Your patch has the line:
 > {{{
 > if [ "$SAGE_APP_DMG" = "no" ]; then
 > }}}
 >
 > This seems to thus bizarrely assume that  SAGE_APP_DMG is either "yes"
 or "no". But it is an environment variable, so can be anything, and
 defaults to being "".   Did you test the above with SAGE_APP_DMG not set?

 Well, apparently as long as you don't have SAGE_APP_DMG being 'no', it
 will make the dmg.   At least, that's what happened when I tested this,
 and Sage worked.  Should I change
 {{{
         echo 'If you wish to create a disk image please set'
         echo 'SAGE_APP_DMG=yes'
 }}}
 to something about
 {{{
         echo 'If you wish to create a disk image please do'
         echo 'unset SAGE_APP_DMG'
 }}}
 or something similar?

 I just don't know what is best; since we want the default to be making a
 dmg, I guess any of these options make it maximally hard to *not* make a
 dmg, but maybe they are not very 'shell-script'-y.  I'm putting this as
 'needs review' again, but feel free to put it back to 'needs work' with
 any comments that would make it better.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7765#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to