#7765: In sage-4.3, the command "sage -bdist" is broken on OS X
-----------------------------------+----------------------------------------
   Reporter:  was                  |       Owner:  tbd       
       Type:  defect               |      Status:  needs_work
   Priority:  blocker              |   Milestone:  sage-4.3.3
  Component:  distribution         |    Keywords:            
     Author:  Karl-Dieter Crisman  |    Upstream:  N/A       
   Reviewer:  William Stein        |      Merged:            
Work_issues:                       |  
-----------------------------------+----------------------------------------
Changes (by GeorgSWeber):

  * status:  needs_review => needs_work


Comment:

 After the patch "trac_7765-dmg.patch" from seven weeks ago, the
 functionality is as (I think) it should be, i.e. unless an environment
 variable "SAGE_APP_DMG" both exists and has a value of "no", the dmg will
 be built. Good.

 As for the documentation/printout statements, one might think of something
 along the following lines to be more verbose:
 {{{
     if [ "$SAGE_APP_DMG" = "no" ]; then
         echo 'If you wish to create a disk image please set'
         echo 'SAGE_APP_DMG=yes'
         echo '(or to anything else but the current SAGE_APP_DMG=no,'
         echo ' or completely unset SAGE_APP_DMG)'
     else
         echo "Creating dmg"
         echo '(If you don't wish to create a disk image please set'
         echo ' SAGE_APP_DMG=no)'
         DYLD_LIBRARY_PATH=$SAGE_ORIG_DYLD_LIBRARY_PATH; export
 DYLD_LIBRARY_PATH
         hdiutil create -srcfolder "$TARGET" -format UDBZ "$TARGET".dmg
     fi
 }}}
 Could you update the patch, or should I do it (I didn't because otherwise
 I couldn't be the reviewer, could I)?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7765#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to