#6961: provide wrapper for psi function of GiNaC
--------------------------------------------------------------------+-------
Reporter: burcin |
Owner:
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-4.3.3
Component: symbolics |
Keywords: psi, gamma, digamma, polygamma
Author: Burcin Erocal |
Upstream: N/A
Reviewer: Karl-Dieter Crisman, Ross Kyprianou, Minh Van Nguyen |
Merged:
Work_issues: |
--------------------------------------------------------------------+-------
Changes (by mvngu):
* status: needs_work => needs_review
* reviewer: Karl-Dieter Crisman, Ross Kyprianou => Karl-Dieter Crisman,
Ross Kyprianou, Minh Van Nguyen
Comment:
I applied patches in the following order against Sage 4.3.3.alpha0,
together with the updated package
[http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.11.spkg
pynac-0.1.11.spkg]:
1. #6961:
[http://trac.sagemath.org/sage_trac/attachment/ticket/6961/trac_6961-psi.rebased.patch
trac_6961-psi.rebased.patch]
1. #7822:
[http://trac.sagemath.org/sage_trac/attachment/ticket/7822/trac_7822-py_log.take2.patch
trac_7822-py_log.take2.patch]
1. #7876:
[http://trac.sagemath.org/sage_trac/attachment/ticket/7876/trac_7876-pynac_print.take2.patch
trac_7876-pynac_print.take2.patch]
1. #7363
1. #7957
1. #7916:
[http://trac.sagemath.org/sage_trac/attachment/ticket/7916/trac_7916-same_name_method.take2.patch
trac_7916-same_name_method.take2.patch]
1. #6465:
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/6465/trac_6465-chain_rule.take2.patch
trac_6465-chain_rule.take2.patch]
1. [http://trac.sagemath.org/sage_trac/attachment/ticket/6465/trac_6465
-moves-integration-into-sfunction-subclass.take3.patch trac_6465-moves-
integration-into-sfunction-subclass.take3.patch]
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/6465/trac_6465-integral.take4.patch
trac_6465-integral.take4.patch]
1. #6559:
1. [http://trac.sagemath.org/sage_trac/attachment/ticket/6559/trac_6559
-domain-and-latex_name-for-variable.take2.3.patch trac_6559-domain-and-
latex_name-for-variable.take2.3.patch]
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/6559/trac_6559-referee.take2.patch
trac_6559-referee.take2.patch]
All doctests passed except for this trivial failure:
{{{
[mv...@sage sage-4.3.3.alpha0.1]$ ./sage -t -long
devel/sage/sage/rings/arith.py
sage -t -long "devel/sage/sage/rings/arith.py"
**********************************************************************
File
"/dev/shm/mvngu/sandbox/sage-4.3.3.alpha0.1/devel/sage/sage/rings/arith.py",
line 287:
sage: factorial(-32)
Expected:
Traceback (most recent call last):
...
ValueError: factorial -- self = (-32) must be nonnegative
Got:
Traceback (most recent call last):
File
"/dev/shm/mvngu/sandbox/sage-4.3.3.alpha0.1/local/bin/ncadoctest.py", line
1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/dev/shm/mvngu/sandbox/sage-4.3.3.alpha0.1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/dev/shm/mvngu/sandbox/sage-4.3.3.alpha0.1/local/bin/ncadoctest.py", line
1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_3[10]>", line 1, in <module>
factorial(-Integer(32))###line 287:
sage: factorial(-32)
File "/dev/shm/mvngu/sandbox/sage-4.3.3.alpha0.1/local/lib/python
/site-packages/sage/rings/arith.py", line 315, in factorial
raise ValueError, "factorial -- must be nonnegative"
ValueError: factorial -- must be nonnegative
**********************************************************************
1 items had failures:
1 of 11 in __main__.example_3
***Test Failed*** 1 failures.
For whitespace errors, see the file
/dev/shm/mvngu/dot_sage/tmp/.doctest_arith.py
[50.3 s]
}}}
The failure is fixed via
[http://trac.sagemath.org/sage_trac/attachment/ticket/6961/trac_6961-doctest.patch
trac_6961-doctest.patch], so only this latter patch needs some reviewing
love. I'm happy with both #6465 and #6559. If my patch is OK, then these 8
tickets can be closed: #6961, #7822, #7876, #7363, #7957, #7916, #6465,
#6559.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6961#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
