#8318: overlap_partion of a word should return an instance disjoint set data
structure
-----------------------------+----------------------------------------------
Reporter: slabbe | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.4
Component: combinatorics | Keywords: equation, words, partition
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by abmasse):
* keywords: => equation, words, partition
* status: needs_review => needs_work
Comment:
Hello, Sébastien !
I tested your patch and generated the documentation. I have some comments
on the latter:
1. The first sentence appears kind of complicated.
Returns the partition of the alphabet induced by the equivalence
relation obtained
from the symmetric, reflexive and transitive closure of the set of pairs
of letters
R_{self,other,delay}\cup p defined below.
I suggest something like:
Returns the partition over the alphabet induced by overlapping the words
self
and other with given delay.
Then you give the formal definition and the example.
2. In the example, it is not clear how the words `cheval` and `abcdef`
overlap. It could be better to use a constant width character font if
possible.
3. You should give more details about what the involution is there for.
4. Same comment about parameter `p`. I prefer more significant name (in
that case, maybe `partition` ?) and it would be nice to know what `p` is
used for (I guess it's a partition corresponding to already equivalent
letters ?)
That's all for now. The rest seems fine. As soon as you fix the
documentation according to my comments, I'll resume the review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8318#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
