#7872: Adding coordinate transformations to plot3d
---------------------------------------------------------------------+------
Reporter: olazo |
Owner:
Type: enhancement |
Status: positive_review
Priority: major |
Milestone: sage-4.3.4
Component: graphics |
Keywords:
Author: Bill Cauchois, Oscar Gerardo Lazo Arjona, Jason Grout |
Upstream: N/A
Reviewer: Karl-Dieter Crisman, Jason Grout |
Merged:
Work_issues: |
---------------------------------------------------------------------+------
Changes (by jason):
* status: needs_review => positive_review
Comment:
Replying to [comment:35 wcauchois]:
> Jason,
> I've taken a look at your code and you've done a great job of cleaning
this up! I can't find any fault with it. Apply the following patches to
Sage 4.3.3: trac-7872-polish.patch, trac_7872_new-all.patch. Applies fine
and passes all doctests.
>
Apply the patches in this order, though: trac_7872_new-all.patch,
trac-7872-polish.patch.
There is precedent for two people collaboratively writing and reviewing
each other's code as being okay. Since you've passed off on my code, and
I've passed off on your code, I'll mark this as positive review. olazo:
can you look at this as well, and if you find a problem, change it back to
needs work?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7872#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
