#8407: word paths isometries + improve construction
-----------------------------+----------------------------------------------
Reporter: slabbe | Owner: slabbe
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.4
Component: combinatorics | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by abmasse):
These functions are really interesting ! I can't wait to use them.
However, here are some comments:
1. I think this patch is a good occasion to add functions such as
`rotate()` and `reflects()` (with pertinent parameters) that compute ONE
rotated or reflected version of the path instead of all EIGHT at the same
time. This wouldn't be too long to do and then your function
`isometries()` could call them.
2. I don't understand why you use the parameter `reversal`. If I
understand it well, it is the word reversal operator, which can be
geometrically interpreted as performing a rotation of angle pi (of the
path) together with an orientation reversal of the path. It seems more
natural to me that the parameter `reversal` correspond simply to the
orientation reversal rather than to the word reversal.
3. I noticed that you do not use the word "self" while documenting, but
you use "path" or other similar words. I'm not sure which one is a good
practice, but I think it is better to use the first one (I'm really not
sure about it, so maybe you can correct me).
What do you think ?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8407#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
