#8370: Add tour_functions to the French tutorial (cf. #5463)
-------------------------------+--------------------------------------------
Reporter: mmezzarobba | Owner: mmezzarobba
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.3.4
Component: documentation | Keywords:
Author: Marc Mezzarobba | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by abmasse):
Hello again Marc !
I reviewed your patch. Everything is ok, I made a few changes which are
not errors, but mainly suggestions, so if you don't agree with any of it,
feel very free to remove them or tell me to remove them. To summarize, I
did the following modifications.
1. Since the tabbing is four spaces for Python code in general (not
mandatory, but encouraged), I reformatted your examples so that they all
start at distance four from the beginning of the lines.
2. For the sage blocks illustrating your examples, you always put `::`
alone on a line, while you could put it at the end of the preceding text
explaining the example. The effect is that the sentence ends with `:` and
the block example follows. This is not a mistake, but this is what I've
seen in other patches.
3. I did some rephrasing. These are only suggestions, if you don't agree
with all or some of it, let me know.
4. You forgot to put the word "plot" between backticks in one place. I
corrected that.
That's pretty much it. As soon as you confirm my changes, I'll be ready to
set this ticket to positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8370#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
