#7288: Gomory-Hu Trees
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.4
Component: graph theory | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by ncohen):
Hello !!
1. It was indeed just to save a line. At some point, I believed it made
the code more readable, as one can directly look at the added constraint,
while the "implicit" iterators are written later, but in the end it just
looks like a sick way to write it ;-)
2. I really do not mind. So in the end, if you think tuples would be
better in this case, this sounds to me like a perfectly good reason to
make it so ! ;-)
3. +1
4. Well. I am a bit lazy, and I thought writing a new function, + new
docstrings just to avoid one parameter (which appears in the proof of the
result, by the way) was a bit too much.. But same thing here : if you
think this should be removed, I see no reason why it should stay...
5. Your fixes in the docstrings : I agree with most of them, but I do not
know what your way of writing INPUT: sections looks like when the
reference is generated. I would like to compare the two :-)
With the comments you made, it sounds like I should rewrite some parts of
the code and sen a new patch, merged with the one you sent. Before doing
it, can you tell me whether you have "pending" modifications on this patch
? If so, could you update your patch ? I will then take it, mix it with
mine, and bring to the code the modifications you requested, but it would
not be a good idea to do it now if you are also working on the same parts
of the code...
Thank you again ! :-)
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7288#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
