#7288: Gomory-Hu Trees
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.4
Component: graph theory | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by abmasse):
I reviewed the patch for what I expect will be the last time ;)
I did the following tests. First, I compiled from source two versions of
sage-4.3.3. Then I installed CBC and GLPK on one of the versions (call
this version the `optional` one) while not installing it on the other
(call that one `basic`). Then, I applied the two patches of #7311 on both
versions and Nathann's patch for #7288.
I tested all sage with the command `sage -testall` on the `basic` version.
All tests passed. On the other hand, I tested both the `sage/numerical`
and `sage/graphs` folders with the command `sage -t -optional`. Once
again, all tests passed ! (I also had to install the package Nauty which
is also needed for optional tests).
Finally, I made some minor changes, touching only the documentation and
some comments in the code. I restested all and the results were the same.
I also looked at the documentation generated by Sphinx. Everything seemed
fine.
Note that other part of codes were also modified by Nathann's patch, but
it only concerns doctests that were failing, so that the graph folder will
be stable in Sage as soon as #7311 and #7288 are merged ! (There were some
optional tests failing even before applying any patch !!!)
To conclude, I give this ticket a positive review, as soon as Nathann
confirms he agrees with my changes.
Great work !
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7288#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
