#7608: upgrade NetworkX to version 1.0.1
---------------------------------+------------------------------------------
Reporter: ylchapuy | Owner: jason
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.4
Component: graph theory | Keywords:
Author: Gregory McWhirter | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by GeorgSWeber):
Hi, I agree that five of the doctest failures are trivial, but I find that
one is at least a bit suspicious:
{{{
File
"/Users/Shared/sage/test/sage-4.3.4.alpha1/devel/sage/sage/graphs/generic_graph.py",
line 6700:
sage:
(graphs.FruchtGraph()).clustering_coeff(nbunch=[0,1,2],with_labels=True,weights=True)
Expected:
({0: 0.33333333333333331, 1: 0.33333333333333331, 2: 0.0}, {0:
0.083333333333333329, 1: 0.083333333333333329, 2: 0.083333333333333329})
Got:
({0: 0.33333333333333331, 1: 0.33333333333333331, 2: 0.0}, {0:
0.33333333333333331, 1: 0.33333333333333331, 2: 0.33333333333333331})
}}}
because the last three numerical values "switched" from 1/12 to 1/3, that
is not "numerical noise". It might just be a functional change in the
networkx core (maybe even a bugfix), but I didn't dig deeper.
If this change is seen by everybody else, I would vote for just adapting
the doctest according to the new behaviour. The good news is that I did a
complete "make test" on sage-4.3.4.alpha1 (with the new spkg, and the last
patch from this ticket attached), and there were no other doctest failures
outside the graphs subdirectory.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7608#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
