#7608: upgrade NetworkX to version 1.0.1
-------------------------------------------+--------------------------------
Reporter: ylchapuy | Owner: jason
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: graph theory | Keywords:
Author: Gregory McWhirter | Upstream: N/A
Reviewer: Minh Van Nguyen, Rob Beezer | Merged:
Work_issues: |
-------------------------------------------+--------------------------------
Changes (by rbeezer):
* reviewer: Minh Van Nguyen => Minh Van Nguyen, Rob Beezer
Comment:
Replying to [comment:49 jason]:
> Looking at your doctest code, it seems that some user code could break
since the output format of the edge function has changed (i.e., edge
labels are not None, but a dictionary). However, this might be
"unavoidable". Definitely we should upgrade networkx!
Hi Jason,
Sorry I missed your ping on IRC. Yes, all I did was copy six missing
doctests. One big patch had many spurious changes (line endings, blank
lines, whatever). Minh did a great service to clean it up, but I think he
simply missed a few tests. I just copied them out of the old patch and
ran tests. And I also ran it against a big script I used to build my
Hoffman-Singleton Graph talk.
Yes, I think the possible break in user code is somewhat out of our hands,
given it was a change in NetworkX. But not bad, given how long its been
since an upgrade.
Short answer - I think it just needs somebody fresh to run tests (on the
whole Sage library?) and call it good. That'd be you. ;-)
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7608#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
