#7555: Fix Cayley tables, add operation tables
---------------------------------+------------------------------------------
Reporter: rbeezer | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.4
Component: algebra | Keywords: cayley table, operation table
Author: Rob Beezer | Upstream: N/A
Reviewer: Nicolas M. Thiéry | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by rbeezer):
* status: needs_work => needs_review
Comment:
Hi Nicolas,
Your changes all look good - thanks for those. Feel free to add yourself
to the author field - it'd be good to "share" a patch with you. So this
is a positive review on those.
With latest "fixup" patch, passes all tests in Sage library, docs build
without warnings and look OK.
Now the ball is in your court. A handful of little things, in a separate
patch so they are easy to isolate.
- self._S is removed, since it is not needed in {{{__getitem__}}} anymore
- "\\cdot" with two backslashesfor latex symbol for generic operation, my
mistake
- four fixes from Jason (above)
- title for reference manual, and GPL header in
sage/matrix/operation_table.py
- fixed a reference to semigroups which has now moved
So I believe you could check these and we'd be done?
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7555#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
