#7555: Fix Cayley tables, add operation tables
---------------------------------+------------------------------------------
Reporter: rbeezer | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.4
Component: algebra | Keywords: cayley table, operation table
Author: Rob Beezer | Upstream: N/A
Reviewer: Nicolas M. Thiéry | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by nthiery):
Replying to [comment:27 rbeezer]:
> Feel free to add yourself to the author field - it'd be good to "share"
a patch with you.
Thanks for the offer! It'd be a pleasure indeed. Now, you really wrote the
bulk of the code. I just did my reviewer's job: all in all, my main code
contribution is the writing of the Magmas category, which is not much and
for which I'll get credit separately.
It was a pleasure working as a team on this patch, and I am looking
forward writing another patch together :-)
> With latest "fixup" patch, passes all tests in Sage library, docs build
without warnings and look OK.
> ...
> So I believe you could check these and we'd be done?
Your fixups look good! I just changed the copyright header as per the
template in http://www.sagemath.org/doc/developer/conventions.html,
and used the occasion to replace a r'\blah' into '\\blah' in the
doctests for consistency with the other occurrences in this file.
I reran the tests on the file itself, and on the category code, which I
believe is sufficient. So, on my account, it's now all good to go. Feel
free to set a positive review once you have double checked my changes.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7555#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
