#8579: Add the categories of magmas and additive magmas
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: nthiery
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: categories | Keywords: categories, magma
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by hivert):
Hi Rob,
Replying to [comment:5 rbeezer]:
> This passes all tests on 4.3.4.final and docs build without any
problems. It also works well when the fairly extensive #7555 is applied
on top of it. So there should be no surprises for the interested
reviewer.
Thanks for checking this.
> I can't say at the moment that I know enough about implementing
categories to verify its completeness, so right now it either (a) needs a
quick review from a knowledgeable category specialist, or (b) I need to
get more education on categories so #7555 can go in.
From the category implementation point of view, everything looks fine upto
the
following small problem which can be left for a future patch: the
{{{SubQuotient}}} code in {{{Semigroups()}}} is sufficiently general to
work
in magmas (computing product by lifting/retracting). It should be moved in
{{{Magmas()}}}.
Otherwise, I'm okay to give a positive review. I'll ask Nicolas directly.
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8579#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
