#8222: sagenb -- misc improvements to the notebook graph editor
----------------------------+-----------------------------------------------
Reporter: was | Owner: rlm
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4
Component: graph theory | Keywords:
Author: Kevin Clark | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by rbeezer):
Replying to [comment:10 rkirov]:
> Hi Rob,
>
> I was waiting to see what Kevin has to say (since I basically took his
code and tweaked with my personal preferences, without consulting with
him). However, I haven't heard back from him.
I'd suggest proceeding with changes and a review, and hope Kevin checks-in
if he feels strongly. If there is a change he's not happy with it, it
could get reverted before being merged (or afterward). I won't do a
review immediately (but will do it soon), so he'll have a chance to weigh-
in if he'd like.
> I wanted to remove auto-maximize, but since it has Kevin's original
work, I wanted to hear back from him. Are you in favor of removing it?
It struck me that it was the source of a lot of wild behavior, without
being crucial to proper functioning, so yes, I'd vote for leaving it out
for right now. It could come back later in a different form.
> If nobody else, says something, I will just make final patch with:
>
> 1) removed red-edges
> 2) removed buttons for maximize and auto-maximize
> 3) switch delete to keyboard 'd'
>
> on the sage side:
>
> 1) add type checking
> 2) incorporate pang's patch (thanks for patch, that was very sloppy of
me)
>
> Then Rob can review it and have the new (in my opinion much superior
version of graph editor) in Sage.
Sounds like a good plan.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8222#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
