#8222: sagenb -- misc improvements to the notebook graph editor
----------------------------+-----------------------------------------------
   Reporter:  was           |       Owner:  rlm         
       Type:  enhancement   |      Status:  needs_review
   Priority:  major         |   Milestone:  sage-4.4    
  Component:  graph theory  |    Keywords:              
     Author:  Kevin Clark   |    Upstream:  N/A         
   Reviewer:  Rob Beezer    |      Merged:              
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by rbeezer):

  * reviewer:  => Rob Beezer


Comment:

 Great improvements!  The "live" layout works great, and I really like the
 way dragging a vertex against the edge makes it appear to bounce off the
 wall.  Turning off auto-maximize was a good idea, I think.

 Tested with 4.3.4 and sagenb-0.7.5.1.  sagenb was updated with all patches
 available to date.

 Passes all tests in sage/graphs, HTML docs build without warnings.

 I have added a reviewer patch.  There was a misspelling on the dialog
 warning about the circular layout change and while I was there I made a
 little change to the tail end of the string.  the patch file is just to
 make it easy to see the change.

 There are also two new comprehensive patches, wrapping everything up
 (including reviewer patch).  Apply {{{trac_8222-sagenb-graph-
 editor.patch}}} to the notebook code and apply {{{trac_8222-sage-graph-
 editor.patch}}} to the sage library repo.

 Rado - This is all ready for a positive review, subject to approval of the
 reviewer patch.  Have a look at that, and if everything looks OK with the
 combined patches, please mark this as positive review and add yourself as
 an author.  Great work! - Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8222#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to