#6781: Library access to ecl
--------------------------------------------------+-------------------------
Reporter: nbruin | Owner: nbruin
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: interfaces | Keywords: ecl, library
Author: Nils Bruin | Upstream: N/A
Reviewer: Burcin Erocal, Karl-Dieter Crisman | Merged:
Work_issues: |
--------------------------------------------------+-------------------------
Comment(by nbruin):
That all looks great. However, I think the PY_NEW call should really be
{{{
cdef EclObject obj = EclObject.__new__(EclObject)
}}}
According to
http://wiki.cython.org/FAQ#CanCythoncreateobjectsorapplyoperatorstolocallycreatedobjectsaspureCcode.3F
it seems that PY_NEW was a hack that was only required prior to Cython
0.12
A lot of the includes are not necessary either for the code to seemingly
work properly. Wouldn't it be better to leave them out?
I am probably not allowed to give the patch a positive review, but I can
confirm that the original reviewer requested those changes to be made and
they look fine to me (the author of the original enhancement).
Thanks for trying to unstall the inclusion of this patch!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6781#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
