#3852: create or adapt or include a units package
---------------------------------------------+------------------------------
Reporter: jason | Owner: somebody
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: basic arithmetic | Keywords:
Author: David Ackerman, William Stein | Upstream: N/A
Reviewer: Dan Drake | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Comment(by burcin):
Thanks for pushing this ticket closer to the finish Dan.
Though I don't think fixing the whitespace problems of
`sage/symbolic/expression.pyx` in
attachment:trac_3852_fix_whitespace.patch is a good idea. There are many
positively reviewed symbolics tickets waiting to be merged on trac and
many of them touch the same file. Pushing the patch on my queue, I get
{{{
applying trac_3852_fix_whitespace.patch
patching file sage/symbolic/expression.pyx
Hunk #7 succeeded at 317 with fuzz 1 (offset -2 lines).
Hunk #208 FAILED at 6448
Hunk #215 FAILED at 6699
Hunk #216 FAILED at 6713
3 out of 236 hunks FAILED -- saving rejects to file
sage/symbolic/expression.pyx.rej
}}}
I don't think rebasing the patch on the other changes is worth it. We
should either have an understanding that this ticket is merged after all
the other actual bug fixes, and the failures in applying this patch are
ignored, or change this patch to fix only the relevant sections of the
file. (Actually, I wouldn't mind if this was a general policy on
whitespace fixes.)
Otherwise, I'm willing to give Dan's changes and this ticket a positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3852#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
