#8500: Add the set of TransitiveGroups
---------------------------------+------------------------------------------
Reporter: nborie | Owner: nborie
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: group_theory | Keywords: transitive group
Author: Nicolas Borie | Upstream: N/A
Reviewer: Nicolas M. Thiéry | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by nborie):
I clearly set a positive review on your reviewer patch!
I had a failure in :
sage -t sage/groups/perm_gps/permgroup_named.py --optional --long
{{{
sage -t --optional --long "devel/sage-
review/sage/groups/perm_gps/permgroup_named.py"
**********************************************************************
File "/opt/sage/devel/sage-
review/sage/groups/perm_gps/permgroup_named.py", line 884:
sage: TransitiveGroup(5,0) # requires optional
database_gap
Expected:
Traceback (most recent call last):
...
AssertionError: n should be in {1,..,5}
Got:
Traceback (most recent call last):
...
assert n > 0
AssertionError
}}}
Thus I propose you a final patch (very easy to review) with a fix of the
doc of TransitiveGroupsAll and a move of an assert on the index of a
transitive group.
Now, all tests long and optional passes. I hope we don't leave any error
in the doc too.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8500#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
