#8500: Add the set of TransitiveGroups
---------------------------------+------------------------------------------
Reporter: nborie | Owner: nborie
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.4
Component: group_theory | Keywords: transitive group
Author: Nicolas Borie | Upstream: N/A
Reviewer: Nicolas M. Thiéry | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by nthiery):
* status: needs_review => positive_review
Comment:
Replying to [comment:14 nborie]:
> I clearly set a positive review on your reviewer patch!
Ok, thanks for checking!
> I had a failure in :
> sage -t sage/groups/perm_gps/permgroup_named.py --optional --long
Oops, I let that one slip through. Thanks for the report!
> Thus I propose you a final patch (very easy to review) with a fix of the
doc of TransitiveGroupsAll and a move of an assert on the index of a
transitive group.
I merged your doc fix in my patch. For the assertion, I fixed the doctest
instead. The message is not as nice, but using assert n>0 has the
(admittedly limited) advantage of failing even if the database is not
there.
With this the patch is good to go. Positive review. Thanks for your work
on this!
I'll now fold the two patches together and upload the final version here.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8500#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
