#8800: Doctest coverage of categories
--------------------------+-------------------------------------------------
   Reporter:  SimonKing   |       Owner:  Simon King         
       Type:  defect      |      Status:  new                
   Priority:  major       |   Milestone:  sage-4.4.1         
  Component:  categories  |    Keywords:  categories doctests
     Author:  Simon King  |    Upstream:  N/A                
   Reviewer:              |      Merged:                     
Work_issues:              |  
--------------------------+-------------------------------------------------
Description changed by SimonKing:

Old description:

> According to William at the doctest coverage of categories is too low:
>
> {{{
> action.pyx: 0% (0 of 31)
> functor.pyx: 17% (3 of 17)
> map.pyx: 27% (10 of 37)
> morphism.pyx: 20% (5 of 24)
> pushout.py: 24% (19 of 77)
> }}}
> Trying to add doc tests, I actually found a bug:
>
> {{{
> sage: abgrps = CommutativeAdditiveGroups()
> sage: ForgetfulFunctor(abgrps, abgrps)
> ---------------------------------------------------------------------------
> TypeError                                 Traceback (most recent call
> last)
>
> /home/king/SAGE/patches/doku/english/<ipython console> in <module>()
>
> /home/king/SAGE/sage-4.3.1/local/lib/python2.6/site-
> packages/sage/categories/functor.so in
> sage.categories.functor.ForgetfulFunctor
> (sage/categories/functor.c:2083)()
>
> TypeError: IdentityFunctor() takes exactly one argument (2 given)
> }}}
> The forgetful functor should coincide with the identity functor, but
> inside ``ForgetfulFunctor``, the latter is called in the wrong way.

New description:

 According to William, the doctest coverage of categories is too low:

 {{{
 action.pyx: 0% (0 of 31)
 functor.pyx: 17% (3 of 17)
 map.pyx: 27% (10 of 37)
 morphism.pyx: 20% (5 of 24)
 pushout.py: 24% (19 of 77)
 }}}
 Trying to add doc tests, I actually found a bug:

 {{{
 sage: abgrps = CommutativeAdditiveGroups()
 sage: ForgetfulFunctor(abgrps, abgrps)
 ---------------------------------------------------------------------------
 TypeError                                 Traceback (most recent call
 last)

 /home/king/SAGE/patches/doku/english/<ipython console> in <module>()

 /home/king/SAGE/sage-4.3.1/local/lib/python2.6/site-
 packages/sage/categories/functor.so in
 sage.categories.functor.ForgetfulFunctor
 (sage/categories/functor.c:2083)()

 TypeError: IdentityFunctor() takes exactly one argument (2 given)
 }}}
 The forgetful functor should coincide with the identity functor, but
 inside ``ForgetfulFunctor``, the latter is called in the wrong way.

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8800#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to