#8786: graph.py: autogenerated broken links to Wikipedia
----------------------------------------------+-----------------------------
Reporter: was | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4.1
Component: documentation | Keywords:
Author: Minh Van Nguyen, Nathann Cohen | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
----------------------------------------------+-----------------------------
Changes (by newvalueoldvalue):
* reviewer: => Minh Van Nguyen
* author: Minh Van Nguyen => Minh Van Nguyen, Nathann Cohen
Old description:
> This is in devel/sage/sage/graphs/graph.py:
> {{{
> class Graph(GenericGraph):
> r"""
> Undirected graph.
>
> A graph is a set of vertices connected by edges
> (cf. http://en.wikipedia.org/wiki/Graph_(mathematics) ).
> }}}
>
> If you look at http://sagemath.org/doc/reference/sage/graphs/graph.html
> and search for "mathematics", then click the link, you'll see it is
> broken. Fix this by:
>
> 1. fixing sphinx? too tricky, maybe
>
> 2. finding sphinx docs and figuring out how to explicitly specify a
> URL.
New description:
This is in devel/sage/sage/graphs/graph.py:
{{{
class Graph(GenericGraph):
r"""
Undirected graph.
A graph is a set of vertices connected by edges
(cf. http://en.wikipedia.org/wiki/Graph_(mathematics) ).
}}}
If you look at http://sagemath.org/doc/reference/sage/graphs/graph.html
and search for "mathematics", then click the link, you'll see it is
broken. Fix this by:
1. fixing sphinx? too tricky, maybe
2. finding sphinx docs and figuring out how to explicitly specify a URL.
Apply patches in the following order:
1. [http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786
-wikipedia-links.patch trac_8786-wikipedia-links.patch]
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-other_fixes.2.patch
trac_8786-other_fixes.2.patch]
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-reviewer.patch
trac_8786-reviewer.patch]
--
Comment:
The patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-other_fixes.2.patch
trac_8786-other_fixes.2.patch] is the same as
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-other_fixes.patch
trac_8786-other_fixes.patch], but with the ticket number in its commit
message. The reviewer patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-reviewer.patch
trac_8786-reviewer.patch] contains the following changes:
* The patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-other_fixes.2.patch
trac_8786-other_fixes.2.patch] does some fixes about broken links. But it
removes the context about why we need such links. Restore that context.
* Some links in
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-other_fixes.2.patch
trac_8786-other_fixes.2.patch] do not link to a Wikipedia article. Correct
such links to point to Wikipedia articles.
So only the following patches now need review by anyone but me:
* [http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786
-wikipedia-links.patch trac_8786-wikipedia-links.patch]
*
[http://trac.sagemath.org/sage_trac/attachment/ticket/8786/trac_8786-reviewer.patch
trac_8786-reviewer.patch]
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8786#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
