#8815: Misc elliptic curve typo fixes (easy review)
-------------------------------+--------------------------------------------
Reporter: robertwb | Owner: cremona
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.4.1
Component: elliptic curves | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by robertwb):
Sorry, my comment was not supposed to be derogatory about the code, it was
supposed to be encouragement that the bug wasn't anything deep (but I can
see how it was taken the wrong way). You're right about C--we need to set
it if it's being used later.
I typically raise a `TypeError` when I get something that's the wrong type
(e.g. I expected a list, but got an integer, or something like that), and
a `ValueError`when it's something about the value (e.g. it was supposed to
be positive, or a prime).
I'll fix the patch, including more doctests.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8815#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
