#8882: Cleanup Combinatorial Free module
------------------------------+---------------------------------------------
Reporter: hivert | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.2
Component: combinatorics | Keywords: Free module
Author: Florent Hivert | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by saliola):
* status: needs_review => needs_work
Comment:
Hello Florent.
You do exactly what is said in the description. But I noticed a few things
that you might want to clean up in '''sage/combinat/free_module.py'''::
* line 824: change 'depend' to 'depends'
* line 844 mentions 'the argument cc', but there is no argument called
'cc'
* line 847: can you use {{{isinstance(args[1], (list,tuple))}}}
instead here?
* line 862: there are some formatting issues (indentation; using
{{{:}}} instead of {{{::}}} and missing a blank line afterwards)
* line 893: there is a 'cc' in the comment
* line 902: it seems that the comment {{{#_prefix = ""}}} is not
necessary
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8882#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
