#8882: Cleanup Combinatorial Free module
------------------------------+---------------------------------------------
Reporter: hivert | Owner: sage-combinat
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-4.4.2
Component: combinatorics | Keywords: Free module
Author: Florent Hivert | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by saliola):
Everything looks good except for one thing. I realize it is not your patch
that created the problem, but since you are poking around in this code, I
figure you might be able to correct it quickly.
In this block of code:
{{{
822 # convert the argument args[2] into a tuple if it is a
list.
823 # note: if args is too short, we still propagate it down
824 # to __init__ to let it handle proper exception raising.
825 if len(args) >= 2 and isinstance(args[1], (list, tuple)):
826 args = (args[0], FiniteEnumeratedSet(args[1])) +
args[2:]
827 return super(CombinatorialFreeModule,
cls).__classcall__(cls, *args, **keywords)
}}}
the comment says that {{{args[2]}}} will be converted into a tuple, but I
don't actually see it happening. Is this a problem, or just a comment that
needs to be deleted?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8882#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
