#8479: numpy support for more basic functions
-----------------------------+----------------------------------------------
Reporter: whuss | Owner: AlexGhitza
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-4.4.2
Component: symbolics | Keywords: numpy
Author: Wilfried Huss | Upstream: N/A
Reviewer: Burcin Erocal | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by burcin):
* status: needs_review => needs_info
* reviewer: => Burcin Erocal
Comment:
The patch looks really good and addresses an important problem. I have a
few minor remarks/questions before I give a positive review:
* Can we change the test in sage.functions.other.sqrt() to work without
importing numpy? I didn't check the effects on performance, but `sqrt()`
gets used a lot, so keeping it free of `numpy` unless absolutely necessary
would be good.
* All the examples in the doctests are for functions with a single
argument. Is there any reason to move the check in
`sage.symbolic.function.Function.__call__()` to try all arguments? We
should also consider moving this check to
`sage.symbolic.function.BuiltinFunction.__call__()`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8479#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
