#8479: numpy support for more basic functions
-----------------------------+----------------------------------------------
   Reporter:  whuss          |       Owner:  AlexGhitza  
       Type:  enhancement    |      Status:  needs_review
   Priority:  major          |   Milestone:  sage-4.4.2  
  Component:  symbolics      |    Keywords:  numpy       
     Author:  Wilfried Huss  |    Upstream:  N/A         
   Reviewer:  Burcin Erocal  |      Merged:              
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by whuss):

  * status:  needs_info => needs_review


Old description:

> The attached patch adds numpy support for the functions:
>
> coth, sech, csch, arccoth, arcsech, arccsch, ceil, floor,
> sqrt, real_part, imag_part, sec, csc, cot, arccot, arccsc,
> arcsec

New description:

 The attached patch adds numpy support for the functions:

 coth, sech, csch, arccoth, arcsech, arccsch, ceil, floor,
 sqrt, real_part, imag_part, sec, csc, cot, arccot, arccsc,
 arcsec, atan2

--

Comment:

 Replying to [comment:4 burcin]:

 > * Can we change the test in sage.functions.other.sqrt() to work without
 importing numpy?

 done in the new patch

 > * All the examples in the doctests are for functions with a single
 argument. Is there any reason to move the check in
 `sage.symbolic.function.Function.__call__()` to try all arguments?

 In the original patch I forgot to add tests for atan2, which also didn't
 work with numpy before. The tests are now included.

 > We should also consider moving this check to
 `sage.symbolic.function.BuiltinFunction.__call__()`.

 Why would this be better? It currently does not have a {{{__call__}}}
 method.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8479#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to