#5117: [with patch] Rename the Polyhedron.union(...) method
----------------------------------+-----------------------------------------
Reporter: sbarthelemy | Owner: mhampton
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.4.2
Component: geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Andrey Novoseltsev
* author: => Volker Braun
Comment:
Looks good to me. I have renamed the original patch file to include the
ticket number and its description. On top of that I have made the
documentation look nicer and added a message to the TyperError exception.
Passes all doctests, so I am giving this a positive review.
My only concern is whether or not we need to use some framework for
deprecating functions or what is done for "union" is enough.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5117#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
