#8490: Bad behavior of is_square_free for Words
--------------------------------------------------+-------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4.2
Component: combinatorics | Keywords: word
Author: Vincent Delecroix, Sébastien Labbé | Upstream: N/A
Reviewer: Mike Hansen | Merged:
Work_issues: |
--------------------------------------------------+-------------------------
Comment(by ncohen):
Hello !! This patch is finem except for a small unimportant thing which
bothered me :
{{{
for end in xrange(start+3, L+1, 3):
}}}
Why go up to L+1 when the last letter is L-1 ? The algorithm is still
correct as
{{{
Word("abc")[:50000]
}}}
raises no exception, but as there is no reason to.... So I give a positive
review to the patches above, and trac_8490_review-ncohen.patch is left to
be reviewed by anyone other than me (quoting Minh) :-)
Thank you for this patch !!
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8490#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
