#8799: Bring doctests for mwrank.pyx up to 100% (from 3%)
-----------------------------+----------------------------------------------
Reporter: cremona | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: documentation | Keywords: mwrank
Author: John Cremona | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by mvngu):
With the patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/8799/trac_8799
-mwrank-doctest.patch trac_8799-mwrank-doctest.patch], I got the following
failures on sage.math:
{{{
[mv...@sage sage-4.4.2.alpha0-8799-mwrank-doctest]$ ./sage -t -long devel
/sage-main/sage/libs/mwrank/mwrank.pyx
sage -t -long "devel/sage-main/sage/libs/mwrank/mwrank.pyx"
**********************************************************************
File "/dev/shm/mvngu/sandbox/sage-4.4.2.alpha0-8799-mwrank-doctest/devel
/sage-main/sage/libs/mwrank/mwrank.pyx", line 428:
sage: E.discriminant()
Expected:
-1269581104000000L
Got:
-1269581104000000
**********************************************************************
File "/dev/shm/mvngu/sandbox/sage-4.4.2.alpha0-8799-mwrank-doctest/devel
/sage-main/sage/libs/mwrank/mwrank.pyx", line 455:
sage: E.conductor()
Expected:
126958110400L
Got:
126958110400
P1 = [0:1:0] is torsion point, order 1
P1 = [-3:0:1] is generator number 1
saturating up to 20...Checking 2-saturation
<output truncated>
Searching for points (bound = 8)...done:
found points of rank 3
and regulator 0.41714355875838396981711954461809339674981010609846
Processing points found during 2-descent...done:
now regulator = 0.41714355875838396981711954461809339674981010609846
No saturation being done
}}}
The reviewer patch fix this issue and a bunch of typos. What we need now
is someone to review the technical aspect of John's patch. Unfortunately,
I'm not at all familiar with elliptic curves.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8799#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
