#8799: Bring doctests for mwrank.pyx up to 100% (from 3%)
-----------------------------------------------+----------------------------
Reporter: cremona | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: documentation | Keywords: mwrank
Author: John Cremona | Upstream: N/A
Reviewer: Minh Van Nguyen, Leif Leonhardy | Merged:
Work_issues: |
-----------------------------------------------+----------------------------
Comment(by leif):
Replying to [comment:17 mvngu]:
> Replying to [comment:16 leif]:
> > Minh, you vote in favour of math-typeset numbers? (I don't like e.g.
{{{`L`-functions}}} either...)
>
> I'm not particularly picky about this issue. What you proposed in your
patches are OK by me.
Well, I haven't reverted your changes of e.g. {{{1}}} to {{{`1`}}}; the
HTML output is not very nice...
> I have folded all our reviewer patches into one cumulative patch.
Yes, of course noticed that.
> I would prefer something like "boolean", "integer", "real number", etc.
Something as "meaningful" as possible, without recourse to type
information.
This might not sound pythonic, but I'd prefer documenting the concrete
type if the function actually expects some Python type (rather than a
duck).
> We now need someone to review the technical (mathematical) aspect of
John's patch,
rlm?
> and a sign off on my review patch.
I've positively reviewed ''your'' changes... :)
So unfortunately someone else (other than John and us) has to review the
cumulative reviewer patch to avoid mutual peer-reviewing on the same
ticket (some people seem to have no problems with this, I do).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8799#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
