#8799: Bring doctests for mwrank.pyx up to 100% (from 3%)
-----------------------------------------------+----------------------------
Reporter: cremona | Owner: cremona
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: documentation | Keywords: mwrank
Author: John Cremona | Upstream: N/A
Reviewer: Minh Van Nguyen, Leif Leonhardy | Merged:
Work_issues: |
-----------------------------------------------+----------------------------
Changes (by cremona):
* owner: mvngu => cremona
Comment:
For what it's worth, thanks again to both, and I am quite happy with the
combined reviewer patch (trac_8799-reviewer-total.patch).
I did not see the typo in the code which Leif mentioned. Is it where we
test height_bound > 21.4 and not 21.48? In that place, it is true that
this could be approximately doubled on 64-bit machines (I guess that when
this code was first written the person doing it did not know how to test
that) but in practice using bounds > 21 will take a very very long time.
So we still need an independent reviewer... and some of the points raised
on this ticket deserve a wider audience, possibly additional sentences in
the developers guide?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8799#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
