#9008: Update zlib to latest upstream, and clean up spkg-install
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: GeorgSWeber
Type: defect | Status: needs_info
Priority: major | Milestone: sage-4.4.3
Component: build | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Description changed by drkirkby:
Old description:
> The zlib package building 32-bit on !OpenSolaris (see #7128), and has
> various hacks to make it build 64-bit on OS X. The spkg-install has
> various hacks, which I think are better implemented other ways.
>
> 1)
> {{{
> -I\"$SAGE_LOCAL/include\""
> }}}
>
> seems better replaced by the command line option available on the
> configure script.
>
> {{{
> --includedir="$SAGE_LOCAL/include"
> }}}
>
> 2) Adding
> {{{
> -m64
> }}}
> is not currently the correct way to make a 64-bit build - the option
>
> {{{
> --64
> }}}
>
> is for that purpose. The developer (Mark Alder) was surprised hacks were
> needed for OS X, as that is his main development platform.
>
> 3) The spkg-install adds
>
> {{{
> -fPIC
> }}}
>
> which apparently is(was) needed on Debian on Itanium. It would seem more
> sensible to add that option just on that platform if it is a problem
> specific to that platform.
>
> This package is much cleaner, but may not work on all platforms. It would
> be better to make the code cleaner, and fix what (if any) issues do
> actually still exist.
>
> Dave
New description:
The zlib package building 32-bit on !OpenSolaris (see #7128), and has
various hacks to make it build 64-bit on OS X. The spkg-install has
various hacks, which I think are better implemented other ways.
1)
{{{
-I\"$SAGE_LOCAL/include\""
}}}
seems better replaced by the command line option available on the
configure script.
{{{
--includedir="$SAGE_LOCAL/include"
}}}
2) Adding
{{{
-m64
}}}
is not currently the correct way to make a 64-bit build - the option
{{{
--64
}}}
is for that purpose. The developer (Mark Alder) was surprised hacks were
needed for OS X, as that is his main development platform.
3) The spkg-install adds
{{{
-fPIC
}}}
which apparently is(was) needed on Debian on Opteron. It would seem more
sensible to add that option just on that platform if it is a problem
specific to that platform.
This package is much cleaner, but may not work on all platforms. It would
be better to make the code cleaner, and fix what (if any) issues do
actually still exist.
Dave
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9008#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
