#9112: adding maximum entry option to SemistandardTableaux()
-----------------------------+----------------------------------------------
Reporter: QuantumKing | Owner: QuantumKing
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.4.3
Component: combinatorics | Keywords: semistandard tableaux
Author: Eric Webster | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by mhansen):
I'm sorry -- I was confused. I thought you were suggesting printing the
maximum entry with each individual tableau rather than with the parent
class. So, ignore my comments regarding that :-)
Regarding the patch, a couple of questions:
1. Why is corners() being changed? It seems unrelated to the ticket.
2. 4 spaces should always be used as the indentation.
3. Any comparisons with None should be used using {{{is}}} instead of
{{{==}}}. For example, {{{if mu is None}}} or {{{if max_entry is not
None}}}. Also, tests like {{{not i == 1}}} should be {{{i != 1}}}.
4. Instead of having -1 represent a max_entry of infinity, I think we
should just use Sage's object for infinity instead.
{{{
sage: type(oo)
<class 'sage.rings.infinity.PlusInfinity'>
sage: SST = SemistandardTableaux(3, max_entry=oo); SST
Semistandard tableaux of size 3 and no maximum entry
}}}
5. {{{raise TypeError, "mu must be of size p (= %s)"%p }}} might be better
as a {{{ValueError}}}.
Other than that, I'm pretty happy with the changes.
You need certain privileges to remove files. If you just post the new
one, I can delete any ones that need to be deleted.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9112#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
