#9160: Singular - change timestamp of files and sort out SAGE64 issue.
------------------------------------------------------+---------------------
   Reporter:  drkirkby                                |       Owner:  
GeorgSWeber 
       Type:  defect                                  |      Status:  
needs_review
   Priority:  blocker                                 |   Milestone:  
sage-4.4.4  
  Component:  build                                   |    Keywords:            
  
     Author:  David Kirkby and Willem Jan Palenstijn  |    Upstream:  N/A       
  
   Reviewer:                                          |      Merged:            
  
Work_issues:                                          |  
------------------------------------------------------+---------------------
Changes (by drkirkby):

  * status:  needs_work => needs_review


Comment:

 I went back to the first version, and made a few minor changes from that.
 So forget the version you did not like. I've overwritten the patch file.

  * Removed the code specific to DYNAMIC_KERNEL on OS X, since as you say,
 it had already been disabled on all platforms except Linux.
  * set CPPFLAGS="-I$SAGE_LOCAL/include $CPPFLAGS" (All flags like -m64, -g
 etc are still there. I've not removed them, though I'm not convinced they
 are needed myself).
  * Added required sections to SPKG.txt according to Developers guide. I
 filled in what I could  - only "PKG Maintainers" is empty.
  * Documented in the new "Special Update/Build Instructions" section about
 Solaris and the use of --without-dynamic-kernel option and CONFIG_SHELL.
 No changes have been made to CONFIG_SHELL or --without-dynamic-kernel.
  * touched src/factory/configure
  * moved SAGE64 stuff outside the debugging section. Even though as you
 say SAGE_DEBUG is set to zero, it still seems illogical to have it in that
 section, as if someone wanted to chage SAGE_DEBUG, they would disable the
 possibility of building 64-bit, which would seem rather stupid.
  * I realised too late my email was not in the commit message, but I don't
 think that should be a major problem. The subject line is more informative
 {{{
 changeset:   93:0283ade6e1ad
 tag:         tip
 user:        kir...@localhost
 date:        Tue Jun 08 16:34:56 2010 -0700
 summary:     #9160. Few code changes, mainly releated to the dynamic
 kernel, and improved documentation
 }}}

 Package is still at
 http://boxen.math.washington.edu/home/kirkby/patches/singular-3.1.0.4.p6.spkg

 The two patches on the ticket need to be applied.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9160#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to