#9223: improve doctest coverage of databases/cremona.py
---------------------------+------------------------------------------------
Reporter: AlexGhitza | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.4.4
Component: doctest | Keywords: cremona elliptic curve database
Author: Alex Ghitza | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Comment(by cremona):
I applied the patch successfully to a 4.4.4.alpha0 build, which did not at
first have the optional database installed. I tested that the command to
install it worked as advertised, and that all tests in
sage/databases/cremona.py passed, with and without -optional. I noticed a
real bug and some cosmetic stuff, and made a new patch (reviewer patch, to
be applied after the main one). Then to test that I went to a different
machine which did not have the optional database installed, applied both
patches and tested the non-optional tests, then installed the optional
database and tested both non-optional and non-optional tests. Phew!
Here's the thing I found of actual substance: in the iterator, the
parameter should be a complete list of conductors, or a generator object,
and *not* the first and last conductor wanted. So in the function and
test as it was, the iterator delivers the three curves of conductor 11 and
nothing else!
Finally, I agree that it is not reasonable to test the (re)-installation
of the database in the normal way, since for a start it takes a long time.
I think we need some input from William on this. Around 2006 I was
updating the database regularly, and giving him access to the new tgz
file, but since then it has happened only rarely. But it is very
important that it still works!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9223#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
