#9223: improve doctest coverage of databases/cremona.py
-----------------------------------------+----------------------------------
   Reporter:  AlexGhitza                 |       Owner:  mvngu                  
        
       Type:  enhancement                |      Status:  positive_review        
        
   Priority:  minor                      |   Milestone:  sage-4.4.4             
        
  Component:  doctest                    |    Keywords:  cremona elliptic curve 
database
     Author:  Alex Ghitza, John Cremona  |    Upstream:  N/A                    
        
   Reviewer:  John Cremona, Alex Ghitza  |      Merged:                         
        
Work_issues:                             |  
-----------------------------------------+----------------------------------
Changes (by newvalueoldvalue):

  * status:  needs_review => positive_review
  * reviewer:  => John Cremona, Alex Ghitza
  * author:  Alex Ghitza => Alex Ghitza, John Cremona


Comment:

 John's reviewer patch looks good to me.  Sorry about the iterator
 business: when I tested that method, I realised that it was broken but for
 some reason I put [11, blah] instead of the [11..blah] that I intended.
 Your revised tests for that also make more sense.

 I agree that we want the database installation code to keep working, but I
 really don't know how/whether we can doctest this.  It's an issue that
 concerns all the databases so it would be good to have a general solution.
 I'd like to ask about this on sage-devel, and if we can get a good method
 going it can be implemented on a new ticket.

 In the meantime, it's better to get the things on this ticket going.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9223#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to