#8988: Add support for toric varieties
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.4
Component: algebraic geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by vbraun):
I've read through the code and it looks good.
One minor issue is that the `_repr_()` is not very descriptive. For
example
{{{
sage: p0 = P1xP1.affine_patch(0)
sage: p0
Toric variety of dimension 2
sage: p0.embedding_morphism()
Scheme morphism:
From: Toric variety of dimension 2
To: Toric variety of dimension 2
Defn: Defined on coordinates by sending [z0 : z3] to
[z0 : 1 : 1 : z3]
}}}
Maybe we could return `Toric variety (dim=2, #cones=4)` or so and include
the number of generating cones to be able to distinguish the different
varieties.
Apart from that I'd be happy to review it positively once the rewritten
`Fan` is incorporated!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8988#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
