#9269: clean up #optional tags in sage/graphs
-----------------------------+----------------------------------------------
Reporter: rlm | Owner: mvngu
Type: defect | Status: positive_review
Priority: major | Milestone:
Component: documentation | Keywords:
Author: Robert Miller | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by jhpalmieri):
Replying to [comment:5 rlm]:
> I did test this,
(Yes, but you weren't the reviewer.)
> and I found something slightly different from what you claim: the script
takes the tags in the doctest and converts them to lower case, while not
doing the same for the command line arguments. So the combination `#
optional - BLAH` plus `-only-optional=blah` works, while neither `#
optional - BLAH` plus `-only-optional=BLAH` nor `# optional - blah` plus
`-only-optional=BLAH` works.
You're right, I mixed this up here (but I think I got it right on #9272).
> In my recent sage-devel post, I mentioned that there is no support for
`OR` in this scheme. My solution was to have doctests requiring GLPK or
CBC to have both listed, and to use `-only-optional=glpk,cbc` when either
is installed.
Right, my question is whether we should put a comment about this at the
top of the affected files, or do we just trust people to know how to use
"-only-optional"?
> I meant to remove CPLEX from *all* the tests, since there is no cplex
package.
I think this flag probably still belongs in {{{mip_cplex.pyx}}}, if no
place else. Someone might have CPLEX installed separately from Sage, and
having a mechanism to test is not a bad idea. ("optional" tags don't need
to correspond to packages, like {{{# optional - internet}}} or {{{#
optional - Mathematica}}}.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9269#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
