#9269: clean up #optional tags in sage/graphs
-----------------------------+----------------------------------------------
Reporter: rlm | Owner: mvngu
Type: defect | Status: positive_review
Priority: major | Milestone:
Component: documentation | Keywords:
Author: Robert Miller | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by rlm):
Replying to [comment:4 jhpalmieri]:
> Two comments: first, this won't work with {{{-only-optional}}} without
the patch from #9272: any line marked {{{# optional - TAGS}}} in which
TAGS contains capital letters can't be tested with {{{-only-optional}}}
because of a bug in sage-doctest. So was this actually tested? I'm
suspicious...
I did test this, and I found something slightly different from what you
claim: the script takes the tags in the doctest and converts them to lower
case, while not doing the same for the command line arguments. So the
combination `# optional - BLAH` plus `-only-optional=blah` works, while
neither `# optional - BLAH` plus `-only-optional=BLAH` nor `# optional -
blah` plus `-only-optional=BLAH` works.
> Second, lines marked {{{# optional - GLPK, CBC}}} require {{{-only-
optional=GLPK,CBC}}} to run: using {{{-only-optional=GLPK}}} won't run
them. That is, if you include several tags on an "optional" line, they
are combined using "and", not "or". I don't think that is what's intended
here. Should we leave it as is, or change it somehow? Or at least
document it somewhere in the file?
In my recent sage-devel post, I mentioned that there is no support for
`OR` in this scheme. My solution was to have doctests requiring GLPK or
CBC to have both listed, and to use `-only-optional=glpk,cbc` when either
is installed.
I meant to remove CPLEX from *all* the tests, since there is no cplex
package.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9269#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
