#8641: "sage -t" should exit with nonzero exit code if doctests fail
----------------------------------------+-----------------------------------
Reporter: ddrake | Owner: ddrake
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.0
Component: doctest | Keywords:
Author: Dan Drake, John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------------+-----------------------------------
Comment(by wjp):
Hm, you're right. I may have mixed up process IDs the previous time I
tried.
In any case, it might make sense to explicitly catch this
{{{KeyboardInterrupt}}}?. But it's not strictly necessary since it'll be
caught on a higher level anyway. (It may be something to save for further
doctesting cleanup patches.)
I don't like the lines {{{err = err | test_file(F)}}}, {{{err = err |
ret}}} and {{{err = err | 2}}}, though. They suggest that {{{err}}} is a
bitmask or boolean, while it isn't. We could make it a bitmask, of course,
so that 0 = all ok, 1 = failed tests, 2 = interrupted, 3 = failed tests
and interrupted. Are there any other special cases we would want to
consider in that case? Maybe a separate bit for timeouts? (See also #9316)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8641#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
