#8989: Add support for Fano toric varieties
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5
Component: algebraic geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by vbraun):
* reviewer: => Volker Braun
Comment:
The functionality is fine, but I would prefer to rename some
methods/variables:
* `delta` -> `nabla`, `P_Delta` -> `delta` everywhere. The "delta in M,
nabla in N" notation works much better in ASCII than `\Delta^\circ`.
* `coordinate_indices` -> `coordinate_name_indices` in order to
distinguish it better from coordinate_points. A doctest would be nice,
too.
In addition to N/M lattice points we now have points of the (dual)
polytope, yay. What does `point_to_variable()` refer to? At the same time
I would like to avoid the lengthy `polyhedron_point_to_variable()`, and
its not easy to find a good name. How about a `nabla_to_variable()` method
that takes either the index of a nabla-point or actual coordinates of a
point and returns the corresponding homogeneous coordinate?
Let me know what you think. After we decide on what to do I'd be happy to
review it positively.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8989#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
