#8988: Add support for toric varieties
----------------------------------+-----------------------------------------
Reporter: novoselt | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: algebraic geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Changes (by davidloeffler):
* status: positive_review => needs_work
Comment:
I couldn't get this patch to apply unless I applied #9062, #8986, #9188
and #8987 beforehand. With these installed on top of 4.5.alpha1 (and no
others), I got a doctest failure:
{{{
> sage -hg qapplied
trac_9062_add_support_for_toric_lattices.patch
trac_8986_add_support_for_convex_rational_polyhedral_cones.patch
trac_9188_fix_facet_normal.patch
trac_9188_fix_facet_normal_reviewer.patch
trac_8987_add_support_for_rational_polyhedral_fans.patch
trac_8987_add_enhanced_cones_and_fans.patch
trac_8987_review_changes.patch
trac_8987_repr_changes.patch
trac_8988_add_support_for_toric_varieties.patch
trac_8988_doctest_fix_for_symbolic_random_tests.patch
> sage -t sage/misc/sageinspect.py
sage -t "devel/sage-reviewing/sage/misc/sageinspect.py"
**********************************************************************
File "/storage/masiao/sage-4.5.alpha1/devel/sage-
reviewing/sage/misc/sageinspect.py", line 983:
sage: sage_getvariablename(A)
Expected:
['A', 'B']
Got:
['B', 'A']
**********************************************************************
1 items had failures:
1 of 8 in __main__.example_22
***Test Failed*** 1 failures.
For whitespace errors, see the file
/home/masiao/.sage//tmp/.doctest_sageinspect.py
[2.9 s]
----------------------------------------------------------------------
The following tests failed:
sage -t "devel/sage-reviewing/sage/misc/sageinspect.py"
Total time for all tests: 2.9 seconds
}}}
I have not got the foggiest clue why toric varieties can possibly have
anything to do with this; it just looks like the doctests for sageinspect
are sensitive to exactly what memory addresses things get stored at. I
will put this back to "needs review" for now, but upload a tiny patch that
sorts the variable name list; if you folks agree that it looks harmless,
then we can go back to positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8988#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
